platform/tdp: remove unnecessary Unimplemented errors
#592
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterfang please review |
msft-jlange
changed the title
Unimplemented errorsUnimplemented errors
peterfang
reviewed
Jan 29, 2025
Several methods of the platform object can be implemented as no-op methods in the TDP environment because there is no required work associated with those methods. There is no need to return an uninmplemented error. With this change, the kernel can boot and execute the test-in-svsm environment on a single vCPU (at least in the Hyper-V configuration which suppresses certain tests). Signed-off-by: Jon Lange <[email protected]>
msft-jlange
added
in-review
|
Looks good to me now, thanks! |
Thanks for reviewing! |
msft-jlange
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several methods of the platform object can be implemented as no-op methods in the TDP environment because there is no required work associated with those methods. There is no need to return an uninmplemented error. With this change, the kernel can boot and execute the test-in-svsm environment on a single vCPU (at least in the Hyper-V configuration which suppresses certain tests).